Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16795 )
Change subject: IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16795/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16795/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2742 PS1, Line 2742: TableIdentifier identifier = : IcebergUtil.getIcebergTableIdentifier(newTable); : newTable.getSd().setLocation(IcebergUtil.loadTable( > I think it's better to add comment here to describe the multiple namespace Extended the above comment. -- To view, visit http://gerrit.cloudera.org:8080/16795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04b75d219e095ce00b4c48f40b8dee872ba57b78 Gerrit-Change-Number: 16795 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 01 Dec 2020 09:38:12 +0000 Gerrit-HasComments: Yes
