Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16795 )

Change subject: IMPALA-10364: Set the real location for external Iceberg tables 
stored in HadoopCatalog
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16795/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/16795/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2738
PS2, Line 2738:                   // When creating external Iceberg table with 
'hadoop.catalog' we load
> line too long (91 > 90)
Done


http://gerrit.cloudera.org:8080/#/c/16795/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2739
PS2, Line 2739:                   // the Iceberg table using catalog location 
and table identifier to get
> line too long (96 > 90)
Done


http://gerrit.cloudera.org:8080/#/c/16795/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2740
PS2, Line 2740:                   // the actual location of the table. This way 
we can also get the
> line too long (93 > 90)
Done



--
To view, visit http://gerrit.cloudera.org:8080/16795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b75d219e095ce00b4c48f40b8dee872ba57b78
Gerrit-Change-Number: 16795
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: wangsheng <[email protected]>
Gerrit-Comment-Date: Tue, 01 Dec 2020 10:40:00 +0000
Gerrit-HasComments: Yes

Reply via email to