Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 )
Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/16741/3/be/src/exprs/CMakeLists.txt File be/src/exprs/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/16741/3/be/src/exprs/CMakeLists.txt@90 PS3, Line 90: A > nit: space Done http://gerrit.cloudera.org:8080/#/c/16741/3/be/src/exprs/iceberg-functions-ir.cc File be/src/exprs/iceberg-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16741/3/be/src/exprs/iceberg-functions-ir.cc@26 PS3, Line 26: > nit: too much spaces Done http://gerrit.cloudera.org:8080/#/c/16741/3/be/src/exprs/iceberg-functions-ir.cc@77 PS3, Line 77: } > maybe we could have a fast-path when input.val is nonnegative, i.e. in that Sure. I added this and the same for decimals. http://gerrit.cloudera.org:8080/#/c/16741/3/be/src/exprs/iceberg-functions-ir.cc@84 PS3, Line 84: n StringVal::null(); > Is this correct formula if decimal_val is negative? Changed it meanwhile in PS4 -- To view, visit http://gerrit.cloudera.org:8080/16741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I485680cf79d96d578dd8cfbfd554bec468fe84bd Gerrit-Change-Number: 16741 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Dec 2020 08:35:48 +0000 Gerrit-HasComments: Yes
