Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16741
to look at the new patch set (#8).
Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition
transforms as built-in functions
......................................................................
WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in
functions
This patch implements Truncate and Bucket partition transforms in Impala BE as
built-in functions. The expectation is that these functions give the same
result as Iceberg's implementation of the same functions. These built-in
functions are invisible so users won't be able to invoke them e.g. from
impala-shell.
Truncate:
- Supported types are IntVal, BigIntVal, StringVal, DecimalVal.
- Receives an input from the above types and a width.
- Returns the same type as the input.
- Expected behaviour is explained here:
https://iceberg.apache.org/spec/#truncate-transform-details
Bucket:
- Supported types are IntVal, BigIntVal, StringVal, DecimalVal, DateVal,
TimestampVal.
- Receives an input from the above types and the number of buckets as IntVal.
- Returns IntVal.
- Expected behaviour is explained here:
https://iceberg.apache.org/spec/#bucket-transform-details
TODO gaborkaszab: This patch is WiP because Decimal support of Bucket transform
is not part of this patch and to be implemented.
Change-Id: I485680cf79d96d578dd8cfbfd554bec468fe84bd
---
M be/src/codegen/impala-ir.cc
M be/src/exprs/CMakeLists.txt
A be/src/exprs/iceberg-functions-ir.cc
A be/src/exprs/iceberg-functions-test.cc
A be/src/exprs/iceberg-functions.h
M be/src/exprs/scalar-expr-evaluator.cc
A be/src/thirdparty/murmurhash/MurmurHash3.cpp
A be/src/thirdparty/murmurhash/MurmurHash3.h
A be/src/thirdparty/murmurhash/README.md
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/function-registry/impala_functions.py
12 files changed, 1,217 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/16741/8
--
To view, visit http://gerrit.cloudera.org:8080/16741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I485680cf79d96d578dd8cfbfd554bec468fe84bd
Gerrit-Change-Number: 16741
Gerrit-PatchSet: 8
Gerrit-Owner: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
