Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16900 )
Change subject: IMPALA-10259: Fixed DCHECK error for backend in terminal state ...................................................................... Patch Set 2: (2 comments) So something I'm not clear on here: is the query that causes the issue supposed to fail the error? If so, why is it that the backend sent a 'done' status report with an OK status at all? It seems to me that is the actual problem - that the backend was apparently not actually done executing (since it hadn't yet hit the error it was supposed to) yet it reported that it was done. http://gerrit.cloudera.org:8080/#/c/16900/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16900/2//COMMIT_MSG@9 PS2, Line 9: cdpd-master This is Apache Impala, please don't reference vendor-specific things like this, as others looking at this review may not know what you're talking about. http://gerrit.cloudera.org:8080/#/c/16900/2/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/16900/2/be/src/runtime/coordinator-backend-state.cc@412 PS2, Line 412: // It's possible to receive status report from backend even num_remaining_instances_ I'm concerned that this approach will have unintended consequences, as there may be other places in Coordinator where we assume that a backend that has reached to 'done' state will no longer have any changes to its state. -- To view, visit http://gerrit.cloudera.org:8080/16900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic12a80e20ddc11e32349edfec2bd16338c24b841 Gerrit-Change-Number: 16900 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 04 Jan 2021 21:57:58 +0000 Gerrit-HasComments: Yes
