Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16900 )
Change subject: IMPALA-10259: Fixed DCHECK error for backend in terminal state ...................................................................... IMPALA-10259: Fixed DCHECK error for backend in terminal state This issue happened for core ASAN build. According to log message, one backend sent status report with instance_exec_status as done for all assigned instances without error, then it sent last status report with error. The coordinator treat the backend state as done after it processed the status report with instance_exec_status as done, but did not apply last status report with error to the overall backend state. This caused backend to receive a response with status as OK for the last status report, hence hit DCHECK error. This patch fix the race for updating the 'Query State' and updating the fragment instance state when hitting error during execution of fragment instance. The backends will not send status report with fragment instance state as "completed" without error after hitting error. Testing: - Manual tests I could only reproduce the situation by adding some artificial delays in the beginning of QueryState::ErrorDuringExecute() when repeatedly running test case test_spilling.py:: TestSpillingDebugActionDimensions::test_spilling_naaj for Impala ASAN build. Verified that the issue did not happen after applying this patch. - Passed exhaustive test. Change-Id: Ic12a80e20ddc11e32349edfec2bd16338c24b841 Reviewed-on: http://gerrit.cloudera.org:8080/16900 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/fragment-instance-state.cc M be/src/runtime/fragment-instance-state.h M be/src/runtime/query-state.cc M be/src/runtime/query-state.h 4 files changed, 38 insertions(+), 12 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic12a80e20ddc11e32349edfec2bd16338c24b841 Gerrit-Change-Number: 16900 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
