Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16917 )

Change subject: IMPALA-10182: Don't add inferred identity predicates to SELECT 
node
......................................................................


Patch Set 2: Code-Review+2

> BTW, as I noted in the test comments, IMPALA-9694 query has an analytic 
> function but it will not show up in the final plan. I tried a couple of 
> variants where it could show up in the plan but those don't throw the 
> original exception. If you have any other failing example, let me know. 
> Thanks.

I can't find a better case neither. I think it's good enough since without this 
patch, I can still reproduce IMPALA-9694. Thanks for fixing this.


--
To view, visit http://gerrit.cloudera.org:8080/16917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I924044f582652dbc50085851cc639f3dee1cd1f4
Gerrit-Change-Number: 16917
Gerrit-PatchSet: 2
Gerrit-Owner: Aman Sinha <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 05 Jan 2021 02:28:02 +0000
Gerrit-HasComments: No

Reply via email to