Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16917 )
Change subject: IMPALA-10182: Don't add inferred identity predicates to SELECT node ...................................................................... IMPALA-10182: Don't add inferred identity predicates to SELECT node For an inferred equality predicates of type c1 = c2 if both sides are referring to the same underlying tuple and slot, it is an identity predicate which should not be evaluated by the SELECT node since it will incorrectly eliminate NULL rows. This patch fixes the behavior. Testing: - Added planner tests with base table and with outer join - Added runtime tests with base table and with outer join - Added planner test for IMPALA-9694 (same root cause) - Ran PlannerTest .. no other plans changed Change-Id: I924044f582652dbc50085851cc639f3dee1cd1f4 Reviewed-on: http://gerrit.cloudera.org:8080/16917 Reviewed-by: Aman Sinha <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test M testdata/workloads/functional-query/queries/QueryTest/inline-view.test 3 files changed, 166 insertions(+), 1 deletion(-) Approvals: Aman Sinha: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I924044f582652dbc50085851cc639f3dee1cd1f4 Gerrit-Change-Number: 16917 Gerrit-PatchSet: 4 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
