wangsheng has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16904 )
Change subject: IMPALA-10368: Support required/optional property when creating Iceberg table ...................................................................... IMPALA-10368: Support required/optional property when creating Iceberg table We supported create required/optional field for Iceberg table in this patch. If we set 'NOT NULL' property for Iceberg table column in SQL, Impala will create required field by Iceberg api, 'NULL' or default will create optional field. Besides, 'DESCRIBE XXX' for Iceberg table will display 'optional' property like this: +------+--------+---------+----------+ | name | type | comment | nullable | +------+--------+---------+----------+ | id | int | | false | | name | string | | true | | age | int | | true | +------+--------+---------+----------+ And 'SHOW CREATE TABLE XXX' will also display 'NULL'/'NOT NULL' property for Iceberg table. Tests: * added new test in iceberg-create.test * added new test in iceberg-negative.test * added new test in show-create-table.test * modify 'DESCRIBE XXX' result in iceberg-create.test * modify 'DESCRIBE XXX' result in iceberg-alter.test * modify create table result in show-create-table.test Change-Id: I70b8014ba99f43df1b05149ff7a15cf06b6cd8d3 --- M fe/src/main/java/org/apache/impala/analysis/ColumnDef.java M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/analysis/TableDef.java M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/Column.java M fe/src/main/java/org/apache/impala/catalog/IcebergColumn.java M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java M fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/util/IcebergSchemaConverter.java M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test 14 files changed, 241 insertions(+), 173 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/16904/4 -- To view, visit http://gerrit.cloudera.org:8080/16904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I70b8014ba99f43df1b05149ff7a15cf06b6cd8d3 Gerrit-Change-Number: 16904 Gerrit-PatchSet: 4 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]>
