Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16904 )
Change subject: IMPALA-10368: Support required/optional property when creating Iceberg table ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Yeah, the success of inserting null values into non-NULL columns is not ideal. Unfortunately Impala currently doesn't check any constraints during insertion. Adding such constraints is a bigger task, I think it makes reasonable to take care of it later. I think the current patch is good as it is, as it helps to more accurately specify the Iceberg schema. It's useful in use-cases when one creates the table via Impala, then loads the data via Spark or some other engine. http://gerrit.cloudera.org:8080/#/c/16904/4/fe/src/main/java/org/apache/impala/analysis/TableDef.java File fe/src/main/java/org/apache/impala/analysis/TableDef.java: http://gerrit.cloudera.org:8080/#/c/16904/4/fe/src/main/java/org/apache/impala/analysis/TableDef.java@454 PS4, Line 454: it's nit: their -- To view, visit http://gerrit.cloudera.org:8080/16904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b8014ba99f43df1b05149ff7a15cf06b6cd8d3 Gerrit-Change-Number: 16904 Gerrit-PatchSet: 4 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 07 Jan 2021 12:40:46 +0000 Gerrit-HasComments: Yes
