Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16939 )
Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms ...................................................................... Patch Set 2: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/16939/2/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/16939/2/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@198 PS2, Line 198: if (unixMicros >= 0) { This means that if unixMicros<0, then we won't do partition pruning, but query will still work, right? http://gerrit.cloudera.org:8080/#/c/16939/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16939/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@186 PS2, Line 186: partSpec.partitionType(), : feIcebergTable.getDefaultPartitionSpec(), dataFile.partitionPath()); nit: +2 indent http://gerrit.cloudera.org:8080/#/c/16939/2/testdata/workloads/functional-planner/queries/PlannerTest/insert.test File testdata/workloads/functional-planner/queries/PlannerTest/insert.test: http://gerrit.cloudera.org:8080/#/c/16939/2/testdata/workloads/functional-planner/queries/PlannerTest/insert.test@976 PS2, Line 976: cast(id * 3 as int), : cast(10000 - id as int) nit: +1 indent? http://gerrit.cloudera.org:8080/#/c/16939/2/testdata/workloads/functional-planner/queries/PlannerTest/insert.test@984 PS2, Line 984: year A potential optimization in timestamp based partitioning expressions could be to remove of the expression from the sorting - this should be correct, as these truncating transformations shouldn't affect the order. Sorting timestamps should be faster than sorting strings, but I am not sure that this worth the effort. -- To view, visit http://gerrit.cloudera.org:8080/16939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3edf02048cea78703837b248c55219c22d512b78 Gerrit-Change-Number: 16939 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 14 Jan 2021 15:33:05 +0000 Gerrit-HasComments: Yes
