Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16939 )
Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms ...................................................................... Patch Set 4: (4 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/16939/3/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: http://gerrit.cloudera.org:8080/#/c/16939/3/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@922 PS3, Line 922: funcNameStr == nu > For string type compared, maybe "funcNameStr.equals("")" is better? Done http://gerrit.cloudera.org:8080/#/c/16939/3/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@944 PS3, Line 944: transfor > typo: transform Done http://gerrit.cloudera.org:8080/#/c/16939/3/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@948 PS3, Line 948: case HOUR: : case MONTH: return "from_timestamp"; : case DAY: return "to_date"; > Shall we use: Done http://gerrit.cloudera.org:8080/#/c/16939/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/16939/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@538 PS3, Line 538: String HIVE_NULL = MetaStoreUtil.DEFAULT_NULL_PA > Shall we use 'DEFAULT_NULL_PARTITION_KEY_VALUE' in MetaStoreUtil to replace Done -- To view, visit http://gerrit.cloudera.org:8080/16939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3edf02048cea78703837b248c55219c22d512b78 Gerrit-Change-Number: 16939 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Fri, 15 Jan 2021 13:31:20 +0000 Gerrit-HasComments: Yes
