Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17095
Change subject: IMPALA-9767: Do not cleanup filter while PublishFilter is ongoing ...................................................................... IMPALA-9767: Do not cleanup filter while PublishFilter is ongoing There has been occurence of heap-use-after-free in ASAN build during runtime filter publish. The root cause of this issue is that bloom filter is being cleaned up while KRPC still sending the filter to workers. This patch remove the offending cleanup routine, decouple cleanup routine from FilterState::DisableAndRelease() into separate method FilterState::Release(), and assert that no rpc is inflight while cleaning up filter. Testing: - Reproduce the bug by instrumenting Coordinator::UpdateFilter(). - Manually verify that the bug does not happen anymore after the patch. - Pass core tests in ASAN build. Change-Id: I1c408bdedab83c4b9249e2c0c493cb0f894a3d08 --- M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/coordinator-filter-state.h M be/src/runtime/coordinator.cc 3 files changed, 18 insertions(+), 20 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/17095/1 -- To view, visit http://gerrit.cloudera.org:8080/17095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1c408bdedab83c4b9249e2c0c493cb0f894a3d08 Gerrit-Change-Number: 17095 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]>
