Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17095 )
Change subject: IMPALA-9767: Do not cleanup filter while PublishFilter is ongoing ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > (10 comments) > > Thanks Riza for working on this fix and also Joe for providing the analysis! > I really appreciate it. :-) > > I am able to reproduce the issue according to suggested steps at IMPALA-9767 > by Riza. I have pushed the patch that reproduces the issue to > https://gerrit.cloudera.org/c/17103/ so that it would be easier for people to > reproduce the issue. Will abandon this patch after the fix by Riza has been > merged. > > Only TPC-DS Q1 with the tpcds/tpcds_parquet database are needed to reproduce > the issue. Building Impala with the 'asan' flag is also required to reproduce > the issue. It seems it is unlikely to crash the coordinator in the local > environment without the 'asan' flag. > > I also verified locally that Riza's patch could avoid that > heap-use-after-free error in my local development environment. > > I only have some minor comments on the commit message. Just to make one of my comments above clearer. I verified locally that before cleaning up the memory consumed by the aggregated Bloom filter, by calling "state->WaitForPublishFilter()" to wait for the completion of the last invocation to Coordinator::BackendState::PublishFilterCompleteCb(), the coordinator won't crash (no heap-use-after-free error). This indicates Riza's fix that defers the release of memory until the completion of the last invocation to Coordinator::BackendState::PublishFilterCompleteCb() would work. -- To view, visit http://gerrit.cloudera.org:8080/17095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c408bdedab83c4b9249e2c0c493cb0f894a3d08 Gerrit-Change-Number: 17095 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sun, 21 Feb 2021 22:19:06 +0000 Gerrit-HasComments: No
