Yida Wu has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/17101


Change subject: IMPALA-10531: Fix 
TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in 
exhaustive release build
......................................................................

IMPALA-10531: Fix 
TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in 
exhaustive release build

Fixed TmpFileMgrTest testcases failed in exhaustive release build.
The cause is that in TmpFileGroup::AllocateRemoteSpace(), it uses
DCHECK to check the return of TmpFileRemote::AllocateSpace(), because
it always returns true, in the release build, the logic is optimized,
so TmpFileRemote::AllocateSpace() isn't called in the release build.
The solution is to use if instead of DCHECK.

Tests:
Reran TmpFileMgrTest/DiskIoMgrTest/BufferPoolTest in the release build.

Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4
---
M be/src/runtime/tmp-file-mgr.cc
1 file changed, 12 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17101/1
--
To view, visit http://gerrit.cloudera.org:8080/17101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4
Gerrit-Change-Number: 17101
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com>

Reply via email to