Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 )
Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17101/4/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17101/4/be/src/runtime/tmp-file-mgr.cc@1029 PS4, Line 1029: shared_ptr<TmpFileRemote> tmp_file_remote(new TmpFileRemote( Why was this change made? Seems like its basically equivalent to the original code, except probably slightly less efficient since the shared_ptr is created and destroyed in the case where we hit one of the two errors below (which means we're doing two extra atomic operations unnecessarily). -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 25 Feb 2021 00:38:43 +0000 Gerrit-HasComments: Yes
