Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17095 )
Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing ...................................................................... IMPALA-9767: Do not clean up filter while PublishFilter is ongoing There have been occurrences of heap-use-after-free in ASAN build during runtime filter publishing. This issue happens because the memory consumed by an aggregated Bloom filter has been released while the coordinator is still sending the aggregated filter via KRPC to workers. This patch removes the offending cleanup routine. This patch also decouples the cleanup routine from FilterState::DisableAndRelease() into a separate method FilterState::Release() and asserts that no RPC is inflight while cleaning up the filter. Testing: - Reproduce the bug by instrumenting Coordinator::UpdateFilter(). - Manually verify that the bug does not happen anymore after the patch. - Pass core tests in ASAN build. Change-Id: I1c408bdedab83c4b9249e2c0c493cb0f894a3d08 Reviewed-on: http://gerrit.cloudera.org:8080/17095 Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/coordinator-filter-state.h M be/src/runtime/coordinator.cc 3 files changed, 18 insertions(+), 20 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/17095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1c408bdedab83c4b9249e2c0c493cb0f894a3d08 Gerrit-Change-Number: 17095 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
