Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test: http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34 PS4, Line 34: 80 > How was this lower bound determined? What happens if things are really slow It was based on several error reports where the total number of pages filtered is in the high 80s (https://master-02.jenkins.cloudera.com/job/impala-asf-master-exhaustive-release/1049/testReport/junit/query_test.test_runtime_filters/TestOverlapMinMaxFilters/test_overlap_min_max_filters_protocol__beeswax___exec_option____batch_size___0___num_nodes___0___disable_codegen_rows_threshold___0___disable_codegen___True___abort_on_error___1___exec_single_node_rows_threshold___0____table_format__parquet_none_/). In my R&D box, the total is over 90. The total number of pages in the two tables remains the same, across these two testing environment. Since the scanner starts the process without waiting for the arrival of filters, this un-determinedness is always there. Setting a value at 80 provides a pretty reasonable lower bound, IMHO :-). -- To view, visit http://gerrit.cloudera.org:8080/17111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972 Gerrit-Change-Number: 17111 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 23 Feb 2021 20:34:39 +0000 Gerrit-HasComments: Yes
