Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test: http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34 PS4, Line 34: 80 > Should we skip this test for sanitizer builds, which are slow? The failures were with exhaustive release build. Tested Sanitize build on my R&D box and observed the same result. http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34 PS4, Line 34: 80 > Well, the scanner should wait at least RUNTIME_FILTER_WAIT_TIME_MS before s Yes, I checked and think you are right. The wait time used during all failed tests was set at 60000ms and the actual arrival time was around 370ms. In all failed tests (exhaustive release), the total number of filtered pages (NumRuntimeFilteredPages) is 128. Therefore the use of 80 as the lower bound is pretty reasonable. http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34 PS4, Line 34: 80 > How was this lower bound determined? What happens if things are really slow It was based on the error report seen -- To view, visit http://gerrit.cloudera.org:8080/17111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972 Gerrit-Change-Number: 17111 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 24 Feb 2021 05:34:35 +0000 Gerrit-HasComments: Yes
