liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 )
Change subject: IMPALA-10377: Improve the accuracy of resource estimation ...................................................................... Patch Set 18: (4 comments) http://gerrit.cloudera.org:8080/#/c/16842/17/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java File fe/src/test/java/org/apache/impala/planner/CardinalityTest.java: http://gerrit.cloudera.org:8080/#/c/16842/17/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@840 PS17, Line 840: + "GROUP BY int_col", AggregationNode.MIN_HASH_TBL_MEM, true, false, > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/16842/17/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@844 PS17, Line 844: + "GROUP BY int_col", AggregationNode.MIN_HASH_TBL_MEM, false, false, > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/16842/17/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@1139 PS17, Line 1139: /** > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/16842/17/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@1168 PS17, Line 1168: /** > line has trailing whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/16842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic01db168ff2c6d6de33ee553a8175599f035d7a1 Gerrit-Change-Number: 16842 Gerrit-PatchSet: 18 Gerrit-Owner: liuyao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: liuyao <[email protected]> Gerrit-Comment-Date: Wed, 24 Feb 2021 08:27:32 +0000 Gerrit-HasComments: Yes
