Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 )
Change subject: IMPALA-10377: Improve the accuracy of resource estimation ...................................................................... Patch Set 18: Code-Review+1 (1 comment) Thanks for applying the changes. The change looks good to me. Could you please resolve the merge conflict? http://gerrit.cloudera.org:8080/#/c/16842/18/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java File fe/src/main/java/org/apache/impala/planner/HashJoinNode.java: http://gerrit.cloudera.org:8080/#/c/16842/18/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@238 PS18, Line 238: ndv of the right child column nit: probably 'NDVs of the columns of the right (build) side?' -- To view, visit http://gerrit.cloudera.org:8080/16842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic01db168ff2c6d6de33ee553a8175599f035d7a1 Gerrit-Change-Number: 16842 Gerrit-PatchSet: 18 Gerrit-Owner: liuyao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: liuyao <[email protected]> Gerrit-Comment-Date: Fri, 26 Feb 2021 13:40:25 +0000 Gerrit-HasComments: Yes
