Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17101 )
Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build ...................................................................... IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build Fixed TmpFileMgrTest testcases failed in exhaustive release build. The cause is that in TmpFileGroup::AllocateRemoteSpace(), it uses DCHECK to check the return of TmpFileRemote::AllocateSpace(), because it always returns true, in the release build, the logic is optimized, so TmpFileRemote::AllocateSpace() isn't called in the release build. The solution is to use if instead of DCHECK. Tests: Reran TmpFileMgrTest/DiskIoMgrTest/BufferPoolTest in the release build. Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Reviewed-on: http://gerrit.cloudera.org:8080/17101 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/tmp-file-mgr.cc 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7320ae41957c44151b7ec17886c383e72c2546e4 Gerrit-Change-Number: 17101 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
