Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17136
Change subject: IMPALA-10529: Fix hit DCHECK in DiskIoMgr::AssignQueue in core-s3 build ...................................................................... IMPALA-10529: Fix hit DCHECK in DiskIoMgr::AssignQueue in core-s3 build In the option of scratch_dirs, it uses absolute paths, doesn't consider the setting of the default filesystem, however, when passing to AssignQueue(), it does consider the default filesystem. For example, if scratch_dirs is set as "/tmp", the scratch dir is supposed to be in the local filesystem, no matter what default filesystem is set. But in the AssignQueue(), by default it considers the default filesystem, so the "/tmp" is treated as "s3a://xxx/tmp" if a s3 path is set as the default fs. To fix this, the solution is to add a variable to ignore the default fs for all of the scratch directories when parsing the paths. Tests: Set the default fs as a s3 path, reran TestDiskSpillConfigurations::test_disk_spill_encryption_disabled and TestQueryRetries::test_query_retry_reaches_spool_limit. Change-Id: Ic07945abe65d90235aa8dea92dd3c3821a4f1f53 --- M be/src/runtime/io/disk-io-mgr.cc M be/src/runtime/io/disk-io-mgr.h M be/src/runtime/io/scan-range.cc M be/src/runtime/tmp-file-mgr.cc 4 files changed, 24 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/17136/1 -- To view, visit http://gerrit.cloudera.org:8080/17136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic07945abe65d90235aa8dea92dd3c3821a4f1f53 Gerrit-Change-Number: 17136 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com>
