Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17136 )
Change subject: IMPALA-10529: Fix hit DCHECK in DiskIoMgr::AssignQueue in core-s3 build ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17136/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17136/2//COMMIT_MSG@23 PS2, Line 23: Set the default fs as a s3 path, reran > Could you add an unit-test? Done http://gerrit.cloudera.org:8080/#/c/17136/2/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17136/2/be/src/runtime/tmp-file-mgr.cc@663 PS2, Line 663: -1, true, false > When you have long parameter lists with constants where its not clear what Done -- To view, visit http://gerrit.cloudera.org:8080/17136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic07945abe65d90235aa8dea92dd3c3821a4f1f53 Gerrit-Change-Number: 17136 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 02 Mar 2021 02:18:33 +0000 Gerrit-HasComments: Yes
