Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15838 )
Change subject: IMPALA-9661: [WIP] Avoid introducing unused columns in table masking view ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/15838/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/15838/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@721 PS2, Line 721: // Fang-Yu: Could consider making the following block a method, e.g., computeResolvedPath(). line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/15838/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@774 PS2, Line 774: // // factory supports column masking. If both of these are false, return the unmasked line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/15838/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/15838/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@279 PS2, Line 279: // tblRef.analyze(analyzer) in FromClause#analyze() (inside that for-loop). line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedc7f15347a50626a9f2aff549bc49338cf73831 Gerrit-Change-Number: 15838 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 02 Mar 2021 17:32:54 +0000 Gerrit-HasComments: Yes
