Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15838 )
Change subject: IMPALA-9661: [WIP] Avoid introducing unused columns in table masking view ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15838/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/15838/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@258 PS2, Line 258: List<TableRef> tableRefs = fromClause_.getTableRefs(); : TableRef leftTblRef = null; : for (int i = 0; i < tableRefs.size(); ++i) { > This approach may not work since it seems to only process the TableRef's im The above analysis does not seem accurate. SelectAnalyzer#analyze() is called for each SelectStmt in a query. As long as this is the case, we should not have the problem mentioned above. -- To view, visit http://gerrit.cloudera.org:8080/15838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedc7f15347a50626a9f2aff549bc49338cf73831 Gerrit-Change-Number: 15838 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 05 Mar 2021 21:20:24 +0000 Gerrit-HasComments: Yes
