Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16407 )
Change subject: IMPALA-10116: Allow unwrapping a builtin cast function similar to CastExpr ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16407/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16407/3//COMMIT_MSG@18 PS3, Line 18: .. nit: , http://gerrit.cloudera.org:8080/#/c/16407/3/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/16407/3/fe/src/main/java/org/apache/impala/analysis/Expr.java@1624 PS3, Line 1624: (this instanceof FunctionCallExpr : && ((FunctionCallExpr) this).isBuiltinCastFunction()) Should we consider 'implicitOnly' in this branch? Is 'implicitOnly' used by the external frontend? http://gerrit.cloudera.org:8080/#/c/16407/3/fe/src/main/java/org/apache/impala/analysis/Expr.java@1625 PS3, Line 1625: isBuiltinCastFunction Should we consider other builtin functions that supposed to keep the same cardinality? -- To view, visit http://gerrit.cloudera.org:8080/16407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf82b2de78c6a7051ea036062f177d69e2558940 Gerrit-Change-Number: 16407 Gerrit-PatchSet: 3 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 24 Mar 2021 04:08:32 +0000 Gerrit-HasComments: Yes
