Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16407 )
Change subject: IMPALA-10116: Allow unwrapping a builtin cast function similar to CastExpr ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16407/3/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/16407/3/fe/src/main/java/org/apache/impala/analysis/Expr.java@1624 PS3, Line 1624: (this instanceof FunctionCallExpr : && ((FunctionCallExpr) this).isBuiltinCastFunction()) > Since a builtin cast function is of type FunctionCallExpr, it does not have Ack http://gerrit.cloudera.org:8080/#/c/16407/3/fe/src/main/java/org/apache/impala/analysis/Expr.java@1625 PS3, Line 1625: isBuiltinCastFunction > Hmm..I suppose there could be other scalar builtin functions to consider f Thanks for the explanation! I'm not aware of any jiras yet. -- To view, visit http://gerrit.cloudera.org:8080/16407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf82b2de78c6a7051ea036062f177d69e2558940 Gerrit-Change-Number: 16407 Gerrit-PatchSet: 4 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 26 Mar 2021 07:16:18 +0000 Gerrit-HasComments: Yes
