Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17228 )
Change subject: IMPALA-10564 (part 2): Fixed test_ctas_exprs failure for S3 build ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17228/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17228/2//COMMIT_MSG@10 PS2, Line 10: But it failed in S3 build with : Parquet format since the table was not successfully created when : CTAS query failed. > When tried to read the table after CTAS, got following error "Query aborted That sounds like a bug though. We shouldn't end up with a corrupt table no matter how the CTAS finished. It might be tricky to fix, and I guess its low priority since the table isn't expected to have meaningful contents anyways, so its okay to go ahead with this patch to unbreak the builds, but you should at least file a JIRA for it http://gerrit.cloudera.org:8080/#/c/17228/2/tests/query_test/test_decimal_queries.py File tests/query_test/test_decimal_queries.py: http://gerrit.cloudera.org:8080/#/c/17228/2/tests/query_test/test_decimal_queries.py@a186 PS2, Line 186: Do we still need to do this check here to ensure that the table we tried to insert into doesn't end up with the null value? http://gerrit.cloudera.org:8080/#/c/17228/2/tests/query_test/test_decimal_queries.py@175 PS2, Line 175: if not ('parquet' in str(vector.get_value('table_format')) and IS_S3): Could you add a comment here explaining why we skip this check for s3? -- To view, visit http://gerrit.cloudera.org:8080/17228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia627ca70ed41764e86be348a0bc19e330b3334d2 Gerrit-Change-Number: 17228 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 25 Mar 2021 00:37:48 +0000 Gerrit-HasComments: Yes
