Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17228 )
Change subject: IMPALA-10564 (part 2): Fixed test_ctas_exprs failure for S3 build ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17228/2/tests/query_test/test_decimal_queries.py File tests/query_test/test_decimal_queries.py: http://gerrit.cloudera.org:8080/#/c/17228/2/tests/query_test/test_decimal_queries.py@a186 PS2, Line 186: > Do we still need to do this check here to ensure that the table we tried to Added back http://gerrit.cloudera.org:8080/#/c/17228/2/tests/query_test/test_decimal_queries.py@175 PS2, Line 175: if not ('parquet' in str(vector.get_value('table_format')) and IS_S3): > Could you add a comment here explaining why we skip this check for s3? Done -- To view, visit http://gerrit.cloudera.org:8080/17228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia627ca70ed41764e86be348a0bc19e330b3334d2 Gerrit-Change-Number: 17228 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 25 Mar 2021 01:04:50 +0000 Gerrit-HasComments: Yes
