Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1 ...................................................................... Patch Set 20: (4 comments) Thanks for the reviews. There are a few TODOs about which I'm not quite sure, could you please help me with them? http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/exec/parquet/hdfs-parquet-scanner.cc@1482 PS20, Line 1482: DCHECK(false); // TODO: Is it possible? Do you think this is a possibility? http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/exec/parquet/hdfs-parquet-scanner.cc@1533 PS20, Line 1533: // TODO: That's what we do for stats filtering. Is it the correct way to handle What do you think of this? http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/exec/parquet/parquet-bloom-filter-util.cc File be/src/exec/parquet/parquet-bloom-filter-util.cc: http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/exec/parquet/parquet-bloom-filter-util.cc@170 PS18, Line 170: *ptr = storage->data(); : *len = storage->size(); > Resizing could be moved inside ParquetBloomFilterEncodeValue to make the ca Done http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/exprs/expr-value.h File be/src/exprs/expr-value.h: http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/exprs/expr-value.h@236 PS20, Line 236: // TODO: Is it OK for all these string types? What do you think of this, especially for TYPE_FIXED_UDA_INTERMEDIATE? -- To view, visit http://gerrit.cloudera.org:8080/17026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287 Gerrit-Change-Number: 17026 Gerrit-PatchSet: 20 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 30 Mar 2021 13:34:19 +0000 Gerrit-HasComments: Yes
