Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1 ...................................................................... Patch Set 23: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17026/23//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17026/23//COMMIT_MSG@7 PS23, Line 7: Part 1 Please mention in the title that this is about read support. http://gerrit.cloudera.org:8080/#/c/17026/23//COMMIT_MSG@10 PS23, Line 10: CHAR(N) Can you add more info about the unsupported type? E.g. Impala type | Problem VARCHAR(N) | truncation can change hash CHAR(N) | padding / truncation can change hash DECIMAL | multiple encodings supported TIMESTAMP:| multiple encodings supported, timezone conversion DATE | ? A follow up Jira could be also created and mentioned here that would add support for more problematic types if possible (e.g DATE, DECIMAL, maybe TIMESTAMP) -- To view, visit http://gerrit.cloudera.org:8080/17026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287 Gerrit-Change-Number: 17026 Gerrit-PatchSet: 23 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Apr 2021 10:22:36 +0000 Gerrit-HasComments: Yes
