Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17249 )
Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/17249/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/17249/2/infra/python/bootstrap_virtualenv.py@87 PS2, Line 87: line[0] == '#': the line could be stripped before doing this http://gerrit.cloudera.org:8080/#/c/17249/2/infra/python/bootstrap_virtualenv.py@107 PS2, Line 107: virtualenv_tarball = \ nit: +2 indentation -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 31 Mar 2021 16:33:42 +0000 Gerrit-HasComments: Yes
