Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17249 )
Change subject: IMPALA-10608 followup: Detect the virtualenv tarball version ...................................................................... IMPALA-10608 followup: Detect the virtualenv tarball version When rebasing from an older commit, the version change in virtualenv can cause there to be multiple virtualenv tarballs of different versions in the infra/python/deps directory. bootstrap_virtualenv.py currently doesn't handle this gracefully, because it is looking for all virtualenv*.tar.gz files and fails when it finds more than one. This changes bootstrap_virtualenv.py to get the virtualenv version from the requirements.txt file and only look for the tarball with that version. If it fails to get the version, it falls back to the old method. Testing: - Copied virtualenv-16.7.10.tar.gz to virtualenv-16.7.9.tar.gz and verified that bootstrap_virtualenv.py works Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Reviewed-on: http://gerrit.cloudera.org:8080/17249 Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- M infra/python/bootstrap_virtualenv.py 1 file changed, 25 insertions(+), 1 deletion(-) Approvals: Joe McDonnell: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iebfa9ba5e223d5187414e02e24f34562418fae40 Gerrit-Change-Number: 17249 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]>
