Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17300 )
Change subject: IMPALA-9732: Improve exceptions of unsupported HdfsTableSink formats ...................................................................... Patch Set 1: Code-Review+2 (3 comments) Nice improvement! http://gerrit.cloudera.org:8080/#/c/17300/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17300/1//COMMIT_MSG@13 PS1, Line 13: eaerlier earlier http://gerrit.cloudera.org:8080/#/c/17300/1//COMMIT_MSG@15 PS1, Line 15: Iceberg Actually Iceberg tables are related because they might use Parquet or ORC underneath. FeIcebergTable inherits from FeFsTable and it overrides 'getFileFormats()' so your patch works well on iceberg tables. http://gerrit.cloudera.org:8080/#/c/17300/1//COMMIT_MSG@16 PS1, Line 16: realted related -- To view, visit http://gerrit.cloudera.org:8080/17300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fa2f949336a422acb4d01c9347b9b2e808e4aec Gerrit-Change-Number: 17300 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Apr 2021 16:44:20 +0000 Gerrit-HasComments: Yes