Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17300 )
Change subject: IMPALA-9732: Improve exceptions of unsupported HdfsTableSink formats ...................................................................... IMPALA-9732: Improve exceptions of unsupported HdfsTableSink formats This change updates the exception that is thrown when the user tries to insert into a partition which has unsupported format. The information to make this decision is available during analysis, therefore this commit also moves the check from the planner to the analyzer to have an earlier result. In the analyzer only the FeFsTables have to be checked therefore Kudu tables are not related. Also, there is a difference between static and dynamic partition clauses, for static partition clauses the partition format is available during compile, for dynaminc partition clauses it is only avaialble during runtime. Testing: - Added unit tests - Ran exhaustive tests successfully Change-Id: I7fa2f949336a422acb4d01c9347b9b2e808e4aec Reviewed-on: http://gerrit.cloudera.org:8080/17300 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M testdata/datasets/functional/functional_schema_template.sql 4 files changed, 78 insertions(+), 21 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7fa2f949336a422acb4d01c9347b9b2e808e4aec Gerrit-Change-Number: 17300 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
