Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 )
Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option ...................................................................... Patch Set 8: Code-Review+1 (8 comments) Thanks for contributing this feature! The solution LGTM. I only have comments on code style. +Aman and Qifan if they want to have a look. http://gerrit.cloudera.org:8080/#/c/17306/8/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/17306/8/be/src/service/query-options.cc@1074 PS8, Line 1074: value nit: interger value http://gerrit.cloudera.org:8080/#/c/17306/8/fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java File fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java: http://gerrit.cloudera.org:8080/#/c/17306/8/fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java@18 PS8, Line 18: package org.apache.impala.rewrite; nit: need a blank line after this http://gerrit.cloudera.org:8080/#/c/17306/8/fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java@22 PS8, Line 22: import org.apache.impala.analysis.Analyzer; nit: need a blank line after this http://gerrit.cloudera.org:8080/#/c/17306/8/fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java@25 PS8, Line 25: * : * */ nit: correct this to */ http://gerrit.cloudera.org:8080/#/c/17306/8/fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java@27 PS8, Line 27: { nit: need a whitespace here http://gerrit.cloudera.org:8080/#/c/17306/8/fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java@41 PS8, Line 41: if (!analyzer.getQueryCtx().client_request.query_options.appx_count_distinct) : return expr; nit: multiline if-statement needs brackets http://gerrit.cloudera.org:8080/#/c/17306/8/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java: http://gerrit.cloudera.org:8080/#/c/17306/8/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@790 PS8, Line 790: session.options().setDefault_ndv_scale(10); For test coverage, could you add a test without this option? i.e. add the following test before this line RewritesOk("ndv(bool_col)", rules, "ndv(bool_col)"); http://gerrit.cloudera.org:8080/#/c/17306/8/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java: http://gerrit.cloudera.org:8080/#/c/17306/8/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@539 PS8, Line 539: nit: remove the blank line at the end -- To view, visit http://gerrit.cloudera.org:8080/17306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1669858a6e8252e167b464586e8d0b6cb0d0bd50 Gerrit-Change-Number: 17306 Gerrit-PatchSet: 8 Gerrit-Owner: fifteencai <fifteen...@tencent.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 13 Apr 2021 07:59:15 +0000 Gerrit-HasComments: Yes
