Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 )
Change subject: IMPALA-10445: Adjust NDV's scale with query option ...................................................................... Patch Set 11: (2 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/17306/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17306/11//COMMIT_MSG@14 PS11, Line 14: y nit: queries http://gerrit.cloudera.org:8080/#/c/17306/11/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java: http://gerrit.cloudera.org:8080/#/c/17306/11/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@539 PS11, Line 539: } The above tests look good! Can we add several more to test the combination of the two new rules: 1. SELECT count(DISTINCT id), ndv(id) FROM functional.alltypes 2. setDefault_ndv_scale(9) and then SELECT count(DISTINCT id), ndv(id) FROM functional.alltypes 3. setDefault_ndv_scale(5) and then SELECT count(DISTINCT id), ndv(id), ndv(id, 10) FROM functional.alltypes 3. setDefault_ndv_scale(5) and then SELECT ndv(id, 10), count(DISTINCT id), ndv(id) FROM functional.alltypes 4. setAppx_count_distinct(true);setDefault_ndv_scale(9) and then SELECT count(DISTINCT id), ndv(id) FROM functional.alltypes -- To view, visit http://gerrit.cloudera.org:8080/17306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1669858a6e8252e167b464586e8d0b6cb0d0bd50 Gerrit-Change-Number: 17306 Gerrit-PatchSet: 11 Gerrit-Owner: fifteencai <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: fifteencai <[email protected]> Gerrit-Comment-Date: Wed, 14 Apr 2021 02:08:08 +0000 Gerrit-HasComments: Yes
