Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17170 )
Change subject: IMPALA-7825: Upgrade Thrift version to 0.11.0 ...................................................................... Patch Set 10: (6 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/17170/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17170/10//COMMIT_MSG@13 PS10, Line 13: boost:: with std:: : shared_ptr-s May need to explain why this is relevant. http://gerrit.cloudera.org:8080/#/c/17170/10//COMMIT_MSG@16 PS10, Line 16: relase nit. rebase or release? http://gerrit.cloudera.org:8080/#/c/17170/10//COMMIT_MSG@27 PS10, Line 27: templates nit: Templates were? http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/rpc/thrift-thread.h File be/src/rpc/thrift-thread.h: http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/rpc/thrift-thread.h@39 PS10, Line 39: false The use of 'false' here seems a deviation from the default value (true) (see https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/concurrency/ThreadFactory.h). Just wonder if this can cause any behavior change. http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/rpc/thrift-util.cc@64 PS10, Line 64: "" May mention something like "Thrift 0.11.0 is required but not present" here. http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/service/impala-server.cc@1536 PS10, Line 1536: ScopedShardedMapRef<shared_ptr<QueryDriver>> map_ref(query_id, &query_driver_map_); Elsewhere in the patch set, std:: is used extensively in .cc files, it may be a good idea to keep std:: in this file too for consistency. -- To view, visit http://gerrit.cloudera.org:8080/17170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd13f177b4f7acc07872ea6399035aa180ef6ab6 Gerrit-Change-Number: 17170 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 20 Apr 2021 14:16:02 +0000 Gerrit-HasComments: Yes
