Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17170 )
Change subject: IMPALA-7825: Upgrade Thrift version to 0.11.0 ...................................................................... Patch Set 13: (7 comments) Thanks for comments! http://gerrit.cloudera.org:8080/#/c/17170/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17170/10//COMMIT_MSG@13 PS10, Line 13: boost:: with std:: : shared_ptr-s > May need to explain why this is relevant. It is simply related to Thrift using std:: instead of boost:: shared_ptr's in 0.11.0 http://gerrit.cloudera.org:8080/#/c/17170/10//COMMIT_MSG@16 PS10, Line 16: releas > nit. rebase or release? Done http://gerrit.cloudera.org:8080/#/c/17170/10//COMMIT_MSG@27 PS10, Line 27: n some ca > nit: Templates were? it is the exact name of a command line option, so I think that it is correct to us it in singular form. http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/rpc/thrift-thread.h File be/src/rpc/thrift-thread.h: http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/rpc/thrift-thread.h@39 PS10, Line 39: /*det > The use of 'false' here seems a deviation from the default value (true) (se True for "detached" would mean that newThread() should return with already detached threads. Our implementation doesn't detach the threads. http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/rpc/thrift-util.cc@64 PS10, Line 64: > May mention something like "Thrift 0.11.0 is required but not present" here Thanks for reminding me about this - I actually at first I didn't to what is asked above in the comment. I have checked now that the error messages didn't change in Thrift code. http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/17170/10/be/src/service/impala-server.cc@1536 PS10, Line 1536: ScopedShardedMapRef<shared_ptr<QueryDriver>> map_ref(query_id, &query_driver_map_); > Elsewhere in the patch set, std:: is used extensively in .cc files, it may specifically in this file shared_ptr is defined and we are using it without std::/boost:: at most lines (e.g. line 1540) It would make sense to use shared_ptr consistently Impalawise (e.g. always use just shared_ptr or always use std::shared_ptr) but I would not do this in this commit. http://gerrit.cloudera.org:8080/#/c/17170/10/shell/ext-py/thrift_sasl-0.4.2/setup.py File shell/ext-py/thrift_sasl-0.4.2/setup.py: http://gerrit.cloudera.org:8080/#/c/17170/10/shell/ext-py/thrift_sasl-0.4.2/setup.py@34 PS10, Line 34: # > nit: whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/17170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd13f177b4f7acc07872ea6399035aa180ef6ab6 Gerrit-Change-Number: 17170 Gerrit-PatchSet: 13 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 20 Apr 2021 20:10:54 +0000 Gerrit-HasComments: Yes
