Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17316 )

Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and 
Azure ABFS
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

Thanks for adding the unit test! Carry Joe's +1 on to +2.

http://gerrit.cloudera.org:8080/#/c/17316/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:

http://gerrit.cloudera.org:8080/#/c/17316/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@584
PS1, Line 584: isPathOnFileSystem
> It also returns true if the parameter is a qualified path (which is always
Ah, yes. Ack



--
To view, visit http://gerrit.cloudera.org:8080/17316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id807e8a200b83283a09d3a917185cabab930017d
Gerrit-Change-Number: 17316
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 22 Apr 2021 06:06:19 +0000
Gerrit-HasComments: Yes

Reply via email to