Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17316 )
Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17316/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/17316/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@588 PS1, Line 588: return fs.exists(path); I wonder if there is a need to call fs.exists(path) here, since a relative path can be technically used to create a file on fs which may not exist currently. Thus, the try block can be as follows to satisfy the question whether 'path' is a valid path on 'fs': try { Path qp = fs.makeQualified(path); return true; } If the semantics is whether 'path' currently locates a file on 'fs', then we need to call fs.exists() (expensive) in all situations. -- To view, visit http://gerrit.cloudera.org:8080/17316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id807e8a200b83283a09d3a917185cabab930017d Gerrit-Change-Number: 17316 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 20 Apr 2021 14:48:19 +0000 Gerrit-HasComments: Yes
