Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17346 )
Change subject: IMPALA-10682: Add buffering to hs2-http client in impala-shell ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17346/2/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/17346/2/shell/impala_client.py@479 PS2, Line 479: elif self.use_kerberos: : transport = TSaslClientTransport(sasl_factory, "GSSAPI", sock) : else: : transport = TSaslClientTransport(sasl_factory, "PLAIN", sock) > Should we wrap this two cases with TBufferedTransport as well? Hmm, thrift's TSaslClientTransport is interesting. It uses puresasl and Attila Jeges also has plans to switch to puresasl. There are many differences in the code (including having a buffer), so this needs some investigation. Dropping thrift_sasl would be a great simplification for Impyla. -- To view, visit http://gerrit.cloudera.org:8080/17346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If11f287be65b10bee2b0afffea118e3dc70fdbbd Gerrit-Change-Number: 17346 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 28 Apr 2021 06:25:29 +0000 Gerrit-HasComments: Yes
