Csaba Ringhofer has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/17346 )

Change subject: IMPALA-10682: Add buffering to hs2-http client in impala-shell
......................................................................

IMPALA-10682: Add buffering to hs2-http client in impala-shell

This change reduces to following command from 8.5s to 1.5s on my
machine:
shell/impala_shell.py -B -q "select * from tpch_parquet.lineitem limit 100000;" 
--protocol hs2-http > /dev/null

This nearly eliminates the speed difference between hs2 and hs2-http.

The root cause of the original slowness is the large number of
calls to socket.recv(). The query above used to call it 2809090 times,
now it is only 9007.

Testing:
- ran shell tests

Change-Id: If11f287be65b10bee2b0afffea118e3dc70fdbbd
Reviewed-on: http://gerrit.cloudera.org:8080/17346
Reviewed-by: Quanlong Huang <[email protected]>
Tested-by: Csaba Ringhofer <[email protected]>
---
M shell/impala_client.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Quanlong Huang: Looks good to me, approved
  Csaba Ringhofer: Verified

--
To view, visit http://gerrit.cloudera.org:8080/17346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If11f287be65b10bee2b0afffea118e3dc70fdbbd
Gerrit-Change-Number: 17346
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Attila Jeges <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>

Reply via email to