Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17387 )
Change subject: IMPALA-10681: [WIP] Fix join cardinality if one side is scalar ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/17387/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/17387/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java@309 PS1, Line 309: // we use one side's NDV values. As a last resort, optimistically assume FK/PK with a line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17387/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java@314 PS1, Line 314: result = getOneSideScalarJoinCardinality(otherEqJoinConjunctSlots, lhsCard, rhsCard); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17387/1/fe/src/main/java/org/apache/impala/planner/JoinNode.java@432 PS1, Line 432: private long getOneSideScalarJoinCardinality(List<EqJoinConjunctScanSlots> eqJoinConjunctSlots, line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa9d3b8f3c4848b3e9414fe19ad7ad348d12ecc Gerrit-Change-Number: 17387 Gerrit-PatchSet: 1 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 03 May 2021 07:31:35 +0000 Gerrit-HasComments: Yes
