Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17387 )
Change subject: IMPALA-10681: Improve join cardinality estimates ...................................................................... Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/17387/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/17387/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java@425 PS2, Line 425: * that instead of the EqJoinConjunctScanSlots, it uses the {@link NdvAndRowCountStats} to line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17387/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java@521 PS2, Line 521: if (lhsExpr instanceof AnalyticExpr || rhsExpr instanceof AnalyticExpr) return null; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17387/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java@522 PS2, Line 522: long lhsNdv = lhsScanSlot != null ? lhsScanSlot.getStats().getNumDistinctValues() : line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17387/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java@524 PS2, Line 524: long rhsNdv = rhsScanSlot != null ? rhsScanSlot.getStats().getNumDistinctValues() : line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17387/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java@528 PS2, Line 528: // In the following num rows assignment, if the underlying scan slot is not available line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17387/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java@529 PS2, Line 529: // we cannot get the actual base table row count. In that case we approximate the row line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17387/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java@530 PS2, Line 530: // count as just the lhs or rhs cardinality. Since the ratio of cardinality/num_rows line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17387/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java@531 PS2, Line 531: // is used to adjust (scale down) the NDV later (when computing join cardinality), it line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17387/2/fe/src/main/java/org/apache/impala/planner/JoinNode.java@538 PS2, Line 538: otherEqJoinConjuncts.add(new NdvAndRowCountStats(lhsNdv, rhsNdv, lhsNumRows, rhsNumRows)); line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa9d3b8f3c4848b3e9414fe19ad7ad348d12ecc Gerrit-Change-Number: 17387 Gerrit-PatchSet: 2 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 19 May 2021 04:20:18 +0000 Gerrit-HasComments: Yes
