Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 )
Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17389/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17389/2//COMMIT_MSG@13 PS2, Line 13: speed It would be nice to have some measurements, for example by adding a large number of casts to a query with many rows so that the cost of casts become measurable. http://gerrit.cloudera.org:8080/#/c/17389/2//COMMIT_MSG@17 PS2, Line 17: 2. Ran existing Backend tests for correctness. Can you add some tests to https://github.com/apache/impala/blob/master/be/src/exprs/expr-test.cc#L3221 ? Having some EE tests is useful, but expression are more widely covered in expr-test.cc -- To view, visit http://gerrit.cloudera.org:8080/17389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic105ad38a2fcbf2fb4e8ae8af6d9a8e251a9c141 Gerrit-Change-Number: 17389 Gerrit-PatchSet: 2 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 04 May 2021 13:16:44 +0000 Gerrit-HasComments: Yes
