Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17389 )

Change subject: IMPALA-10680: Replace StringToFloatInternal using 
fast_double_parser library
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

LGTM!

http://gerrit.cloudera.org:8080/#/c/17389/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17389/3//COMMIT_MSG@10
PS3, Line 10: strod
strtod


http://gerrit.cloudera.org:8080/#/c/17389/3//COMMIT_MSG@13
PS3, Line 13: accurancy
accuracy



--
To view, visit http://gerrit.cloudera.org:8080/17389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic105ad38a2fcbf2fb4e8ae8af6d9a8e251a9c141
Gerrit-Change-Number: 17389
Gerrit-PatchSet: 3
Gerrit-Owner: Amogh Margoor <[email protected]>
Gerrit-Reviewer: Amogh Margoor <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 12 May 2021 16:08:50 +0000
Gerrit-HasComments: Yes

Reply via email to