Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17413 )
Change subject: [WIP]IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr ...................................................................... Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/disk-io-mgr.cc@628 PS1, Line 628: // << static_cast<int>(range->external_buffer_tag()) << " invalid to allocate buffers " line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/request-ranges.h File be/src/runtime/io/request-ranges.h: http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/request-ranges.h@256 PS1, Line 256: /// Acquire lock_ of the ScanRange. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/request-ranges.h@548 PS1, Line 548: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/request-ranges.h@553 PS1, Line 553: /// client calls ReturnBuffer(). line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-buffer-manager.h File be/src/runtime/io/scan-buffer-manager.h: http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-buffer-manager.h@39 PS1, Line 39: /// Creates ScanBufferManager for a ScanRange. Created store will take care of buffer line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-buffer-manager.h@78 PS1, Line 78: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-buffer-manager.cc File be/src/runtime/io/scan-buffer-manager.cc: http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-buffer-manager.cc@159 PS1, Line 159: DCHECK(scan_range_lock.mutex() == &(lock_store_->lock_) && line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-range.cc@58 PS1, Line 58: // // One or more threads may be blocked in WaitForInFlightRead() waiting for the read line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-range.cc@63 PS1, Line 63: // // Clean up any surplus buffers. E.g. we may have allocated too many if the file was line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-range.cc@127 PS1, Line 127: // || unused_iomgr_buffer_bytes_ >= len_ - iomgr_buffer_cumulative_bytes_used_) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-range.cc@356 PS1, Line 356: // // Close the scan range if there are no more buffers in the reader and no more buffers line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-range.cc@369 PS1, Line 369: // for (unique_ptr<BufferDescriptor>& buffer : buffers) CleanUpBuffer(lock, move(buffer)); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-range.cc@473 PS1, Line 473: LOG(ERROR) << "Held onto too many buffers " line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17413/1/be/src/runtime/io/scan-range.cc@677 PS1, Line 677: buffer_manager_->external_buffer_tag_ = ScanBufferManager::ExternalBufferTag::CACHED_BUFFER; line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd74691b50b46114f95a8641034c05d07ddeec97 Gerrit-Change-Number: 17413 Gerrit-PatchSet: 1 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 08 May 2021 13:51:26 +0000 Gerrit-HasComments: Yes
