Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17413 )
Change subject: [WIP]IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17413/2/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17413/2/be/src/runtime/io/disk-io-mgr.cc@628 PS2, Line 628: // << static_cast<int>(range->external_buffer_tag()) << " invalid to allocate buffers " line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17413/2/be/src/runtime/io/scan-buffer-manager.h File be/src/runtime/io/scan-buffer-manager.h: http://gerrit.cloudera.org:8080/#/c/17413/2/be/src/runtime/io/scan-buffer-manager.h@78 PS2, Line 78: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/17413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd74691b50b46114f95a8641034c05d07ddeec97 Gerrit-Change-Number: 17413 Gerrit-PatchSet: 2 Gerrit-Owner: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Sun, 09 May 2021 22:21:26 +0000 Gerrit-HasComments: Yes
